This repository has been archived by the owner on Nov 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Issue 39 #51
Merged
Merged
Issue 39 #51
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2b988d5
progress on test #39
TheoPannetier 9f1c875
#39
OggyOggelito cb2dd0b
test for #39
TheoPannetier 3c88e98
space is continous
TheoPannetier 5c52d09
finished #39
martprenger 25ca0ba
Fixed merge conflict
OggyOggelito 5f4b9dd
Update player.cpp
martprenger 7bdd9f8
worked on the changes of pull request review
martprenger dd33481
Merge branch 'issue_39' of https://github.com/tresinformal/basketball…
martprenger 1d07f5c
worked on the changes of pull request review
martprenger 7872475
Merge branch 'develop' into issue_39
martprenger c0f81a1
fixed pr review
martprenger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not the intended solution by the test (the field's line should probably not be a property of the player!), but it does address the test. I'll allow it for now, eventually we'll have to break this (in #52).