Checks selection from wanda #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
force-pushed
the
checks-selection-from-wanda
branch
from
d305245 to
868cf90
Compare
arbulu89
requested review from
dottorblaster,
nelsonkopliku,
fabriziosestito,
CDimonaco,
EMaksy,
jamie-suse and
rtorrero
arbulu89
force-pushed
the
checks-selection-from-wanda
branch
2 times, most recently
from
dca1bca to
781c316
Compare
dottorblaster
suggested changes
Nov 29, 2022
Comment on lines
12
to
14
| allSelected, | ||
| someSelected, | ||
| noneSelected, |
There was a problem hiding this comment.
This is overly complicated, you can simplify this providing just a prop or two, like selected. You can then export some constants like NONE, ALL, or SOME to control this behavior from outside, but the entrypoint would be unique.
There was a problem hiding this comment.
I have ended adding the states into an "enum" (js doesn't have proper enums, so a dictionary does the work, the values of the map don't have any meaning).
Let me know if you like it or not. I can move them to individual constants otherwise
| ...check, | ||
| selected: isSelected(check.id), | ||
| })); | ||
| const allSelected = checks.every((check) => isSelected(check.id)); |
There was a problem hiding this comment.
Suggested change
| const allSelected = checks.every((check) => isSelected(check.id)); | |
| const allSelected = checks.every(({ id }) => isSelected(id)); |
arbulu89
force-pushed
the
checks-selection-from-wanda
branch
from
2fa0f97 to
ab30f8e
Compare
dottorblaster
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace current checks selection view to use data coming from wanda.
Almost the complete work consists on having the checks selection view components in smaller pieces, beforehand everything was a unique view.
Besides that, I have introduced in the last commit the concept of
actionsin a new folder. There, we can have the actions and their constants defined and reuse the dispatched actions. I think we should do this for all the logical components at some point, at the moment where we do the folder/file restructureHow was this tested?
Tests added