Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ui restyle of Health box in HealthSummary #944

Merged
merged 2 commits into from
Nov 3, 2022
Merged

Conversation

CDimonaco
Copy link
Member

@CDimonaco CDimonaco commented Nov 2, 2022

Description

As title.

We add a smart component for the health boxes with the new UI style and the ability to acts as button with a 'selected" state, like a checkbox. This is done for preparing the boxes health filtering feature.

Tag @jagabomb for ui review

image

The style of the boxes changes in all the views.

How was this tested?

Manually.

@CDimonaco CDimonaco added ux javascript Pull requests that update Javascript code labels Nov 2, 2022
@CDimonaco CDimonaco self-assigned this Nov 2, 2022
@CDimonaco CDimonaco changed the title Ui restyle of Health boxed in HealthSummary Ui restyle of Health box in HealthSummary Nov 2, 2022
@abravosuse
Copy link
Contributor

Code apart, looks good to me.

@CDimonaco CDimonaco force-pushed the ui_restyle_health_boxes branch from e00f0ba to 466ff45 Compare November 2, 2022 20:08
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jagabomb jagabomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CDimonaco CDimonaco merged commit 8ec47a3 into main Nov 3, 2022
@CDimonaco CDimonaco deleted the ui_restyle_health_boxes branch November 3, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code ux
Development

Successfully merging this pull request may close these issues.

4 participants