Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add end-to-end tests for KVM & Nutanix cloud providers #897

Merged
merged 2 commits into from
Oct 14, 2022

Conversation

jamie-suse
Copy link
Contributor

Description

Adds end-to-end tests to check that using the cloud providers KVM or Nutanix displays them correctly in the Host Detail view.

Original change: #885

How was this tested?

Added Cypress tests to check that using the cloud providers KVM or Nutanix displays them correctly in the Host Detail view.

@jamie-suse jamie-suse requested a review from arbulu89 October 14, 2022 08:59
Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @jamie-suse ,
I proposed a bit stricter check, but you can change and merge without needing other review

test/e2e/cypress/integration/host_details.js Outdated Show resolved Hide resolved
@jamie-suse jamie-suse force-pushed the e2e-tests-kvm-nutanix branch from 3bd5c17 to 9a801de Compare October 14, 2022 09:25
@jamie-suse jamie-suse merged commit 7cb0aaa into main Oct 14, 2022
@jamie-suse jamie-suse deleted the e2e-tests-kvm-nutanix branch October 14, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants