Add mix deps.unlock --check-unused to CI #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
reviewed
Oct 5, 2022
|
@arbulu89 yeah you're right, because we had a cache hit. Let's see if removing unused dependencies triggers the step |
|
@arbulu89 yeah looks like now the step was correctly executed, thanks for the heads up |
| @@ -56,6 +56,7 @@ jobs: | |||
| mix local.rebar --force | |||
| mix local.hex --force | |||
| mix deps.get | |||
| mix deps.unlock --check-unused | |||
There was a problem hiding this comment.
I am late to the party, but this should be a listing step of "Static code analysis"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the team agreed upon during the planning, we are adopting
mix deps.unlock --check-unusedin our CI.Fixes # (issue)
Did you add the right label?
Aye
How was this tested?
If the CI is happy, we are I guess