Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community eula #854

Merged
merged 5 commits into from
Sep 29, 2022
Merged

Community eula #854

merged 5 commits into from
Sep 29, 2022

Conversation

arbulu89
Copy link
Contributor

@arbulu89 arbulu89 commented Sep 29, 2022

Description

Add Premium vs Community eula distinction.
Selection_453

Did you add the right label?

Yes

How was this tested?

Jest tests added.
PD: intersection-observer package is needed to run the tests correctly. Ref: https://stackoverflow.com/questions/57008341/jest-testing-react-component-with-react-intersection-observer

@arbulu89 arbulu89 added the enhancement New feature or request label Sep 29, 2022
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple comments then we can merge

assets/js/components/Eula/Eula.jsx Outdated Show resolved Hide resolved
assets/js/components/Eula/Eula.test.jsx Outdated Show resolved Hide resolved
assets/js/state/sagas/index.js Outdated Show resolved Hide resolved
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arbulu89 arbulu89 merged commit 59785b9 into main Sep 29, 2022
@arbulu89 arbulu89 deleted the community-eula branch September 29, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants