Show warning unknown check selection #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
requested review from
dottorblaster,
fabriziosestito,
nelsonkopliku,
jagabomb and
abravosuse
arbulu89
force-pushed
the
show-warning-unknown-check-selection
branch
from
f220510 to
b9e7877
Compare
arbulu89
force-pushed
the
show-warning-unknown-check-selection
branch
from
b9e7877 to
8347ede
Compare
dottorblaster
suggested changes
Sep 23, 2022
fabriziosestito
approved these changes
Sep 23, 2022
|
@arbulu89 Looks great! Minor point for the future is that I should have made the border radius 8px for the warning box. I realised that the two different pages have inconsistencies with the container border radii. An 8px border is more commonly used throughout the UI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include warning message in the check selection and results if the provider is unknown (out of azure,aws,gcp,nutanix,kvm):