Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor docker compose to add named volume for postgres persistence #797

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Refactor docker compose to add named volume for postgres persistence #797

merged 1 commit into from
Sep 6, 2022

Conversation

CDimonaco
Copy link
Member

We remove the local binding of docker compose in the project root.

We add a named docker-compose volume in order to maintain the persistence of postgres but avoid binding in the local directory with polluted data.

@CDimonaco CDimonaco self-assigned this Sep 6, 2022
arbulu89
arbulu89 approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@CDimonaco CDimonaco merged commit 0266ae0 into main Sep 6, 2022
@CDimonaco CDimonaco deleted the refactor_docker_compose_volumes branch September 6, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arbulu89 arbulu89 arbulu89 approved these changes

@fabriziosestito fabriziosestito fabriziosestito approved these changes

@dottorblaster dottorblaster dottorblaster approved these changes

Assignees

@CDimonaco CDimonaco

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CDimonaco @dottorblaster @fabriziosestito @arbulu89