Set version with git #735
Set version with git #735
Conversation
arbulu89
requested review from
dottorblaster,
fabriziosestito and
nelsonkopliku
mix.exs
Outdated
| end | ||
|
|
||
| defp get_version_from_git do | ||
| case File.cwd!() |> Path.join("hack/get_version_from_git.sh") |> System.cmd([]) do |
There was a problem hiding this comment.
I am wondering whether this is necessary here.
What I mean is that we're setting the VERSION env variable at build time by using get_version_from_git.sh so, do we really need to do that here? 🤔
The alternative I see would be: either at build time the VERSION has been set, or we fallback to the default version.
Am I missing something? would that work? Would that even make sense?
There was a problem hiding this comment.
Yes, I guess you are right. I just implemented this way to have the way to debug it in my development environment.
We can delete this case, no issues with it.
Ok, I will remove it for the sake of simplicity
There was a problem hiding this comment.
Edit: Ok, now I know why I have added it...
It was for the community version. The VERSION replacement only affect the suse container, but the community doesn't have such a replacement or Dockerfile edition, and the docker/build-push-action@v3 job doesn't make it that straightforward.
@nelsonkopliku This makes me reconsider the removal of the script usage in the code hehe, as I don't like having string replacements in the community dockerfile. I will check what I can do there, maybe I can use env variables or something like that...
There was a problem hiding this comment.
Oh I see, is that the reason why e2e tests are failing?
Anyway, no strong opinion from my side. It is just fine like you did. 💪
There was a problem hiding this comment.
and the docker/build-push-action@v3 job doesn't make it that straightforward.
ah I see, have to say I am not a big fan of executing shell scripts from elixir but if there is not another way i am ok with it
arbulu89
force-pushed
the
set-version-with-git
branch
from
0ae42db to
13319a8
Compare
arbulu89
force-pushed
the
set-version-with-git
branch
from
ce04477 to
6500dcd
Compare
In order to get the version of the rolling container, this PR includes a new way of getting the application version. It uses the next order:
VERSIONenv variable during the release creationhack/get_version_from_git.shscript outputPD: I have already checked solutions like edeliver, but they look more complicated than the thing we really need. Anyway, if there is any better way of doing so, I'm all open to apply it!