Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle DAA and unknown sap system payloads #702

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Handle DAA and unknown sap system payloads #702

merged 1 commit into from
Jul 12, 2022

Conversation

arbulu89
Copy link
Contributor

Handle SAP system payloads with DAA and unknown types.

  • The httpsPort is not required now as the DAA instance doesn't have it (and maybe other neither)
  • Only known system types are accepted

It accommodates the code for new changes in the agent: trento-project/agent#55

@arbulu89 arbulu89 added the bug Something isn't working label Jul 12, 2022
@arbulu89 arbulu89 merged commit 85b0f04 into main Jul 12, 2022
@arbulu89 arbulu89 deleted the handle-daa-type-sap-system branch July 12, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelsonkopliku nelsonkopliku nelsonkopliku approved these changes

@fabriziosestito fabriziosestito fabriziosestito approved these changes

@rtorrero rtorrero Awaiting requested review from rtorrero

Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arbulu89 @fabriziosestito @nelsonkopliku