Add a modal to display remediation info on check results #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtorrero
requested review from
nelsonkopliku,
arbulu89,
fabriziosestito,
abravosuse,
dottorblaster and
stefanotorresi
and removed request for
nelsonkopliku,
arbulu89 and
fabriziosestito
abravosuse
approved these changes
Jun 23, 2022
arbulu89
reviewed
Jun 23, 2022
There was a problem hiding this comment.
The code looks good overall.
Not a big fan of the modals though, more when we are using collapsible rows everywhere else.
But if the PO like, I'm fine with it.
You have green light from me, just have a look on my comments, and feel free to change (if you want of course hehe)
PD: I guess that at some point we could use this information box to show some more information about why the check failed too
Me linking this idea VERY MUCH :-) I will add a user story for it... |
rtorrero
force-pushed
the
add-clickable-remediation
branch
from
9296eae to
951cb62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a modals where users can check the remediation details from the check results screen by clicking on the check result row. In action: