Ecto decode cloud discovery #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottorblaster
force-pushed
the
ecto-decode-cloud-discovery
branch
2 times, most recently
from
ec988b6 to
1dd2bb6
Compare
dottorblaster
requested review from
fabriziosestito,
rtorrero,
arbulu89 and
nelsonkopliku
| provider_data: | ||
| case metadata do | ||
| %{ | ||
| compute: %{ |
There was a problem hiding this comment.
could we have a function here instead of a case?
There was a problem hiding this comment.
I would have something like:
defp build_update_provider_command(agent_id, %CloudDiscoveryPayload{
provider: :azure,
metadata: metadata
}) do
...
To handle the different provider overtime, instesad of the case option
arbulu89
approved these changes
May 25, 2022
There was a problem hiding this comment.
Nice work @dottorblaster !
I agree on the comment given by @fabriziosestito on splitting the metadata building process by providers
lib/trento/application/integration/discovery/payloads/cloud_discovery_payload.ex
Show resolved
Hide resolved
lib/trento/application/integration/discovery/payloads/cloud_discovery_payload.ex
Show resolved
Hide resolved
lib/trento/application/integration/discovery/payloads/cloud_discovery_payload.ex
Show resolved
Hide resolved
| provider_data: | ||
| case metadata do | ||
| %{ | ||
| compute: %{ |
There was a problem hiding this comment.
I would have something like:
defp build_update_provider_command(agent_id, %CloudDiscoveryPayload{
provider: :azure,
metadata: metadata
}) do
...
To handle the different provider overtime, instesad of the case option
dottorblaster
force-pushed
the
ecto-decode-cloud-discovery
branch
from
1dd2bb6 to
d7ab945
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decoding cloud discovery payload using Ecto.