Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reactive subscription #495

Merged
merged 2 commits into from
May 5, 2022
Merged

Reactive subscription #495

merged 2 commits into from
May 5, 2022

Conversation

fabriziosestito
Copy link
Member

Adds reactiveness to the subscription section on the host details page, and move it to the bottom of the page.

@fabriziosestito fabriziosestito requested review from dottorblaster, arbulu89, nelsonkopliku and rtorrero and removed request for dottorblaster May 5, 2022 07:46
@fabriziosestito fabriziosestito force-pushed the reactive_subscription branch from 003eb88 to f4da374 Compare May 5, 2022 07:50
arbulu89
arbulu89 approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!
At some point we might decide to hide even more the subscriptions table somehow, as it uses a lot of space and it is not that important. This for the future though hehe

@dottorblaster dottorblaster merged commit 74f0961 into main May 5, 2022
@dottorblaster dottorblaster deleted the reactive_subscription branch May 5, 2022 08:12
@arbulu89 arbulu89 added the enhancement New feature or request label Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arbulu89 arbulu89 arbulu89 approved these changes

@nelsonkopliku nelsonkopliku nelsonkopliku approved these changes

@dottorblaster dottorblaster dottorblaster approved these changes

@rtorrero rtorrero Awaiting requested review from rtorrero

Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fabriziosestito @dottorblaster @nelsonkopliku @arbulu89