Update the usage of the spinner icon during checks execution #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
requested review from
dottorblaster,
fabriziosestito,
rtorrero,
stefanotorresi,
nelsonkopliku and
abravosuse
fabriziosestito
suggested changes
Apr 28, 2022
There was a problem hiding this comment.
Are we sure we want to remove the spinner component?
It seems that now to have a spinner you have to remember which class to apply to the icon and so on, components are a nice way to remove boiler code like this.
I would still use the EOS icon, but inside a spinner component.
arbulu89
force-pushed
the
set-spinner-properly
branch
from
58e5f85 to
1002697
Compare
arbulu89
force-pushed
the
set-spinner-properly
branch
from
1002697 to
1167409
Compare
dottorblaster
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the EOS loading image. I have removed the initial
Spinnercomponent, as the we can easily use the eos one.