Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sap system column usage in the host list overview #387

Merged
merged 2 commits into from
Apr 20, 2022

Conversation

arbulu89
Copy link
Contributor

Fix an error that was happening when some partial data in the SAP system state was received. Besides that, now the sap system column data is updated live properly (when new discovery events are received).

@arbulu89 arbulu89 added the bug Something isn't working label Apr 20, 2022
@arbulu89 arbulu89 force-pushed the fix-sapsystem-field-host-overview branch from 2dee1a9 to 1d889c2 Compare April 20, 2022 13:26
Copy link
Contributor

@rtorrero rtorrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

assets/js/components/HostsList.jsx Outdated Show resolved Hide resolved
assets/js/components/HostsList.jsx Outdated Show resolved Hide resolved
@rtorrero
Copy link
Contributor

Btw, this addresses #382

@arbulu89 arbulu89 requested a review from dottorblaster April 20, 2022 14:02
@dottorblaster dottorblaster merged commit fc1d830 into main Apr 20, 2022
@dottorblaster dottorblaster deleted the fix-sapsystem-field-host-overview branch April 20, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

3 participants