Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add collector endpoint, host discovery integration event handler and monitoring context #34

Merged
merged 6 commits into from
Dec 30, 2021
Merged

Add collector endpoint, host discovery integration event handler and monitoring context #34

merged 6 commits into from
Dec 30, 2021

Conversation

fabriziosestito
Copy link
Member

This PR adds:

  • a module transform discovery events in domain commands
  • the monitoring context
  • an /api/collect API endpoint which is compatible with the current trento agent

Missing:
tests

dottorblaster
dottorblaster approved these changes Dec 30, 2021
View reviewed changes
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lib/tronto_web/router.ex Outdated Show resolved Hide resolved
@fabriziosestito @dottorblaster
Fixone
4bb73f6 
Co-authored-by: Alessio Biancalana <[email protected]>
@fabriziosestito fabriziosestito merged commit b362faa into master Dec 30, 2021
@fabriziosestito fabriziosestito deleted the add_collect_endpoint branch December 30, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dottorblaster dottorblaster dottorblaster approved these changes

@nelsonkopliku nelsonkopliku Awaiting requested review from nelsonkopliku

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabriziosestito @dottorblaster