Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add not found page #338

Merged
merged 2 commits into from
Apr 12, 2022
Merged

Add not found page #338

merged 2 commits into from
Apr 12, 2022

Conversation

fabriziosestito
Copy link
Member

@fabriziosestito fabriziosestito commented Apr 11, 2022 •
edited
Loading

image

@fabriziosestito fabriziosestito force-pushed the add_not_found_page branch 4 times, most recently from 2526a40 to ba54bc4 Compare April 11, 2022 18:35
nelsonkopliku
nelsonkopliku approved these changes Apr 12, 2022
View reviewed changes
Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🏰

arbulu89
arbulu89 approved these changes Apr 12, 2022
View reviewed changes
assets/js/components/NotFound/NotFound.jsx Outdated
<div className="container mx-auto px-6 flex flex-col-reverse lg:flex-row justify-between items-center relative">
<div className="w-full mb-16 md:mb-8 text-center lg:text-left">
<h1 className="font-light font-sans text-center lg:text-left text-5xl lg:text-8xl mt-12 md:mt-0 text-gray-700">
Sorry,<br></br>the page is in antoher castle.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is antoher some sort of joke that I don't get it? hehe

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super mario bros :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arbulu89 now i get it it was a typo: "another"

@fabriziosestito fabriziosestito merged commit 6da4eb9 into main Apr 12, 2022
@fabriziosestito fabriziosestito deleted the add_not_found_page branch April 12, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arbulu89 arbulu89 arbulu89 approved these changes

@nelsonkopliku nelsonkopliku nelsonkopliku approved these changes

@dottorblaster dottorblaster dottorblaster approved these changes

@rtorrero rtorrero Awaiting requested review from rtorrero

@stefanotorresi stefanotorresi Awaiting requested review from stefanotorresi

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fabriziosestito @dottorblaster @nelsonkopliku @arbulu89