Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Health overviews #320

Merged
merged 7 commits into from
Apr 11, 2022
Merged

Health overviews #320

merged 7 commits into from
Apr 11, 2022

Conversation

nelsonkopliku
Copy link
Member

@nelsonkopliku nelsonkopliku commented Apr 7, 2022 •
edited
Loading

Hosts Overview
image

Clusters Overview
image

SAP Systems Overview
image

HANA Databases Overview
image

@nelsonkopliku nelsonkopliku marked this pull request as ready for review April 7, 2022 19:49
@nelsonkopliku nelsonkopliku requested a review from abravosuse April 7, 2022 19:54
fabriziosestito
fabriziosestito approved these changes Apr 11, 2022
View reviewed changes
Copy link
Member

@fabriziosestito fabriziosestito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except the size maybe we can have a follow up PR to reduce it

@nelsonkopliku nelsonkopliku merged commit 81a30b8 into main Apr 11, 2022
@nelsonkopliku nelsonkopliku deleted the health_overviews branch April 11, 2022 08:12
@abravosuse
Copy link
Contributor

Arriving late @nelsonkopliku but just wanted to say that looks awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziosestito fabriziosestito fabriziosestito approved these changes

@dottorblaster dottorblaster Awaiting requested review from dottorblaster

@rtorrero rtorrero Awaiting requested review from rtorrero

@arbulu89 arbulu89 Awaiting requested review from arbulu89

@stefanotorresi stefanotorresi Awaiting requested review from stefanotorresi

@abravosuse abravosuse Awaiting requested review from abravosuse

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nelsonkopliku @abravosuse @fabriziosestito