Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SUSE Manager errors label computation #3092

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

dottorblaster
Copy link
Contributor

@dottorblaster dottorblaster commented Oct 22, 2024

The computation for the SUSE Manager status of the host was wrong. Even when the errors weren't critical it reported SUMA connection not working. This PR fixes it making the unknown state reachable again.

Testing

Jest tests both updated and added

@dottorblaster dottorblaster self-assigned this Oct 22, 2024
@dottorblaster dottorblaster marked this pull request as ready for review October 24, 2024 08:53
@dottorblaster dottorblaster force-pushed the fix-labels-suma-errors branch from 0632c1f to 791a2c4 Compare October 24, 2024 08:54
Copy link
Member

@janvhs janvhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something went wrong 👀 /j

Copy link
Member

@EMaksy EMaksy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something went wrong... but everything went right with this pr !

@dottorblaster dottorblaster merged commit 25ab801 into main Oct 24, 2024
30 checks passed
@dottorblaster dottorblaster deleted the fix-labels-suma-errors branch October 24, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants