Fix navigation still possible from host details to SUSE Manager pages in case of error #3061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottorblaster
force-pushed
the
suse-manager-indicator-navigation-fix
branch
from
dabe3a1 to
97735ba
Compare
dottorblaster
force-pushed
the
suse-manager-indicator-navigation-fix
branch
from
32276eb to
7c73af1
Compare
dottorblaster
force-pushed
the
suse-manager-indicator-navigation-fix
branch
from
7c73af1 to
2af3b0b
Compare
janvhs
approved these changes
Oct 21, 2024
| @@ -16,19 +16,21 @@ function Indicator({ | |||
| isError, | |||
| onNavigate, | |||
| }) { | |||
| const clickHandler = isError ? () => {} : onNavigate; | |||
|
|
|||
| return ( | |||
| <Tooltip isEnabled={isError} content={tooltip} wrap={false}> | |||
| <div | |||
| role="button" | |||
There was a problem hiding this comment.
Just realised: should this change to a link when navigating?
There was a problem hiding this comment.
In order to have clickable elements that trigger an event accessible also through keyboard a role="button" has to be specified, it was not my first course of action but eslint was pretty clear about that 😄
We can revisit it in the future if we see fit, thanks for the tip 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing navigation still possible from host details to suma pages in case of error.
How was this tested?
Existing tests passing, I would like to add a Jest test to ensure it doesn't go off anymore.