Remove Phoenix.View and use the new Phoenix.Component structure #3055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EMaksy
requested review from
dottorblaster,
CDimonaco and
arbulu89
and removed request for
dottorblaster
arbulu89
reviewed
Oct 9, 2024
There was a problem hiding this comment.
@EMaksy It looks great.
The unique thing that we should do is to move the view functions and files to the controller folders themselves, as suggested by phoenix documentation, and we should do the same in wanda, as we forgot. (we already discussed this offline as well)
EMaksy
force-pushed
the
migrate_phoenix_to_1.7
branch
from
b652ef3 to
2411447
Compare
|
Thanks for the review, as mentioned by @arbulu89 opened a follow up pr on wanda |
EMaksy
force-pushed
the
migrate_phoenix_to_1.7
branch
from
2411447 to
817e573
Compare
dottorblaster
approved these changes
Oct 10, 2024
nelsonkopliku
pushed a commit
that referenced
this pull request
Oct 11, 2024
* Replace Phoenix.View from config * Update json rendering to 1.7 standards * Update VIEW test to JSON tests * Remove old views * Update html structure without Phoenix.View * Fix suse_manager_json rendering * Clean up code * Apply suggestions * Refactor function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR has the main goal to update Trento Web console to Phoenix 1.7 standards
What has been done ?
Removed Phoenix.View and replaced it with Phoenix.Component/HTML
Updated configs for new html and json rendering
Replaced old view modules with json modules with new style of json rendering
Updated Projectors when required for JSON rendering
Added components/core component and layouts to fit new Phoenix directory structure
Updated heex templates
Added verified routes
Updated existing controllers for json rendering
Switched some functions to private when not used elsewhere
What has been not done?
Phoenix View was not completely removed as currently Swoosh still uses it, there are ways to remove Phoenix.View, but i would prefer to do it when Swoosh officially removes Phoenix.View.
Check out the discussion and official docs
This PR relates to wanda trento-project/wanda#513
How was this tested?
Updated all existing tests
Added test for about json view