-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix table overflow and pagination rounded border #3031
Conversation
5b6bac9
to
691bd06
Compare
@nelsonkopliku I like how this fixes the usability of the dropdown component. I think we would still need to apply to Here are a couple of examples were it is missing the rounded effect: Another suggestion would be to change the position of the dropdown since the CSS in the previous PR creates a mask across all elements within the table. Therefore changing the position of the dropdown to the top of the selector would be quick-fix. 😅 |
hey @jagabomb thanks for the suggestion, that's pretty smart. However it is not that straightforward changing the position of the options listbox, our current version (1.7) of headless ui does not support that well, while version 2 does, but we still don't have version 2 available #2881 If you have some pointers on how to do what you suggest with what we have currently, please share 😄 |
@nelsonkopliku Cool, I can imagine headless ui 2.0 is not ready to merge. I was thinking of a simpler solution, so if we take the Select component and give it a |
bff4644
to
f703ec8
Compare
f703ec8
to
1d1d761
Compare
Awesome @jagabomb! Thanks a lot for the help, I could have lost myself in tailwind to find the correct class 🙈 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! 🚀
Description
the overflow hidden added to the table component in this PR #3010 prevented the items per page selection to be properly shown.
I moved the necessary classname to the pagination component.