Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance messages for tagging/untagging activities #3019

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Enhance messages for tagging/untagging activities #3019

merged 1 commit into from
Sep 25, 2024

Conversation

nelsonkopliku
Copy link
Member

Description

This PR allows to have more human friendly messages for the activity log: tagging and untagging entries.

Tag "the-added-tag" added to Host "the-hostname"
Tag "the-removed-tag" removed from Cluster "the-clustername"

Same goes for Databases and SAP Systems

How was this tested?

Automated tests added.

@nelsonkopliku nelsonkopliku self-assigned this Sep 25, 2024
@nelsonkopliku nelsonkopliku added the enhancement New feature or request label Sep 25, 2024
@nelsonkopliku nelsonkopliku added the javascript Pull requests that update Javascript code label Sep 25, 2024
@nelsonkopliku nelsonkopliku merged commit 82216d3 into main Sep 25, 2024
85 of 86 checks passed
@nelsonkopliku nelsonkopliku deleted the improve-tagging-log-messages branch September 25, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balanza balanza balanza approved these changes

@gagandeepb gagandeepb Awaiting requested review from gagandeepb

Assignees

@nelsonkopliku nelsonkopliku

Labels
enhancement New feature or request javascript Pull requests that update Javascript code
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nelsonkopliku @balanza