Improve Activity Log page request lifecycle #3016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| setLoading(false); | ||
| }); | ||
| // defer the loading state to avoid flickering | ||
| const tid = setTimeout(() => setActivityLogRequest(request.loading()), 500); |
There was a problem hiding this comment.
question: how can the flickering be reproduced?
There was a problem hiding this comment.
Good question, it is something visually annoying that has no functional effect. Maybe it only applies to local executions, when the latency is near zero.
There was a problem hiding this comment.
Alright thanks for clarifying.
balanza
force-pushed
the
activity-log-spinner
branch
2 times, most recently
from
12a996f to
24a75cc
Compare
nelsonkopliku
approved these changes
Sep 27, 2024
balanza
force-pushed
the
activity-log-spinner
branch
from
24a75cc to
cb379d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refine how the Activity log page handles the API request
lib/api/request