Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate real runner execution usage #300

Merged
merged 8 commits into from
Apr 5, 2022
Merged

Integrate real runner execution usage #300

merged 8 commits into from
Apr 5, 2022

Conversation

arbulu89
Copy link
Contributor

@arbulu89 arbulu89 commented Apr 5, 2022

Implement the real runner check execution request process.

It includes:

  • New table with host connection settings. By now, it only contains the connection user. This table is empty always now, and it will be populated from the frontend, using some sort of form, as we do now in old trento
  • Post execution request message to the runner
  • Include the skipped state to the check results enum

TODO:

  • Handle check results with unreachable state in the hosts
  • Provide the correct provider for the execution
  • Store the user from the web frontend

@arbulu89 arbulu89 added the enhancement New feature or request label Apr 5, 2022
@arbulu89 arbulu89 force-pushed the integrate-real-runner-execution-usage branch from b8ef136 to 3cb6b95 Compare April 5, 2022 12:16
nelsonkopliku
nelsonkopliku approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

dottorblaster
dottorblaster approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arbulu89
Copy link
Contributor Author

arbulu89 commented Apr 5, 2022

@fabriziosestito All the changes done! Thank you

@fabriziosestito fabriziosestito merged commit 2dbab14 into main Apr 5, 2022
@fabriziosestito fabriziosestito deleted the integrate-real-runner-execution-usage branch April 5, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelsonkopliku nelsonkopliku nelsonkopliku approved these changes

@fabriziosestito fabriziosestito fabriziosestito approved these changes

@dottorblaster dottorblaster dottorblaster approved these changes

@rtorrero rtorrero Awaiting requested review from rtorrero

@stefanotorresi stefanotorresi Awaiting requested review from stefanotorresi

Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arbulu89 @dottorblaster @fabriziosestito @nelsonkopliku