Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity log metadata enrichment #2996

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Conversation

nelsonkopliku
Copy link
Member

@nelsonkopliku nelsonkopliku commented Sep 18, 2024

Description

This PR introduces a MetadataEnricher enriching metadata extracted from activity parsing.

Depends on #2992, see also #2951

The rationale behind is improving human-friendly identification of the resource the activity log entry is related to and improving log searchability.

The thing could be summarized as: adding a human friendly resource name to the activity log metadata when it does not already have one

  • host -> hostname - field named hostname
  • cluster -> cluster name - field named name
  • database -> sid - field named sid
  • sap system -> sid - field named sid
  • application instance -> instance number (always present when needed, no enrichment required)
  • database instance -> instance number (always present when needed, no enrichment required)

I just kept field names as they come from the read model (that is why we have hostname for a host and name for a cluster).
Had thought of options where:

  • we always enrich with component_name|resource_name|name or the like
  • making name for clusters clustername to be consistent with hostname

Open for feedback.

How was this tested?

Automated tests.

@nelsonkopliku nelsonkopliku force-pushed the activity-log-metadata-enrichment branch from 6acf01d to da7d3a1 Compare September 19, 2024 07:08
@nelsonkopliku nelsonkopliku marked this pull request as ready for review September 19, 2024 07:15
@nelsonkopliku nelsonkopliku self-assigned this Sep 19, 2024
@nelsonkopliku nelsonkopliku added enhancement New feature or request user story elixir Pull requests that update Elixir code labels Sep 19, 2024
@nelsonkopliku nelsonkopliku force-pushed the activity-log-metadata-enrichment branch from 61d2864 to 03f6d8c Compare September 19, 2024 08:49
Copy link

dpulls bot commented Sep 20, 2024

🎉 All dependencies have been resolved !

Base automatically changed from expose-components-retrieval-by-id to main September 20, 2024 09:47
@nelsonkopliku nelsonkopliku force-pushed the activity-log-metadata-enrichment branch from 03f6d8c to 67bdbb4 Compare September 20, 2024 09:49
@nelsonkopliku nelsonkopliku merged commit 624fa97 into main Sep 20, 2024
30 checks passed
@nelsonkopliku nelsonkopliku deleted the activity-log-metadata-enrichment branch September 20, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
elixir Pull requests that update Elixir code enhancement New feature or request user story
Development

Successfully merging this pull request may close these issues.

3 participants