Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show page stats when data set is empty #2994

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Conversation

nelsonkopliku
Copy link
Member

Description

When showing PageStats for an empty dataset shows inconsistent values.
This change makes sure PageStats is not even rendered if the total of items is 0

Screenshot from 2024-09-18 10-29-41

How was this tested?

Automated tests and storybook.

@nelsonkopliku nelsonkopliku self-assigned this Sep 18, 2024
@nelsonkopliku nelsonkopliku added bug Something isn't working javascript Pull requests that update Javascript code labels Sep 18, 2024
Copy link
Member

@janvhs janvhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this :D

@nelsonkopliku nelsonkopliku merged commit b6b3095 into main Sep 18, 2024
85 of 86 checks passed
@nelsonkopliku nelsonkopliku deleted the fix-page-stats branch September 18, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working javascript Pull requests that update Javascript code
Development

Successfully merging this pull request may close these issues.

3 participants