Refactor <DateFilter>
#2960
Merged
Refactor <DateFilter>
#2960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 11, 2024
balanza
force-pushed
the
fix-date-filter
branch
from
5daa8f4 to
d6bf6e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Being it uses the browser native
<input type="datetime-local">HTML element, the component needs to convert dates in the local timezone from/to UTC.This PR uses formatting instead of timezone offset, so the conversion is idempotent if applied multiple times.
This avoid the need to control balance the number of conversion from and to the target timezone (as it's the case in a controlled component scenario)