Enhance <Pagination> component
#2918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balanza
requested review from
janvhs and
dottorblaster
and removed request for
janvhs
|
There are some failing tests after the refactor. They happen because they rely on checks based on internal implementations that may not be valid anymore. The problem is that I don't know if they fail also because the new implementation breaks some behavior. I have to investigate ed eventually to refactor tests as well. |
janvhs
approved these changes
Aug 26, 2024
balanza
force-pushed
the
implement-react-paginate
branch
from
6c3aa79 to
6df98a8
Compare
balanza
force-pushed
the
implement-react-paginate
branch
from
6df98a8 to
2a0abd8
Compare
This was referenced Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor the
<Pagination>component using the libraryreact-paginate