-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add developer guide for oidc #2907
Conversation
2ef246b
to
50664a2
Compare
This guide should help the rest of the team to quickly start a dev env locally, anything else we should include? |
50664a2
to
82c24cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments:
- I would rename the
oidc
folder tointegration
- Don't write
Identity Provider (IDP)
more than once. Once it is referenced, use the short version. The same for OIDC
710b591
to
46b9d3f
Compare
Thanks @arbulu89 i updated the docs and also added additional information from your pr about e2e |
46b9d3f
to
b558b42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more comments 🙈
Typo in the folder intergration
-> integration
f68fcc5
to
3efb6c5
Compare
3efb6c5
to
11454fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @EMaksy
Green light
Description
This pr includes a little guide how to enable oidc.
Additionally, this documentation should help developers quickly run Trento web with keycloak to test and develop oidc tasks.
Did you update the documentation?
This pr is in addition for developers to the manual installation trento-project/docs#53