Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose info about existence of prev/next page #2882

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

nelsonkopliku
Copy link
Member

Description

Exposes has_previous_page and has_next_page boolean info as part of the pagination response.

It comes handy to allow/disallow back/forth navigation actions when we know there are no items.

How was this tested?

Automated tests.

@nelsonkopliku nelsonkopliku self-assigned this Aug 8, 2024
@nelsonkopliku nelsonkopliku added enhancement New feature or request user story elixir Pull requests that update Elixir code labels Aug 8, 2024
@nelsonkopliku nelsonkopliku force-pushed the expose-activity-log-has-next-prev-page branch from 48cb88c to 55c54ab Compare August 8, 2024 13:42
Copy link
Contributor

@gagandeepb gagandeepb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks, especially, for adding the pagination schema object.

@nelsonkopliku nelsonkopliku force-pushed the expose-activity-log-has-next-prev-page branch from 55c54ab to f868a6b Compare August 8, 2024 14:17
@nelsonkopliku nelsonkopliku merged commit a7953b7 into main Aug 8, 2024
27 checks passed
@nelsonkopliku nelsonkopliku deleted the expose-activity-log-has-next-prev-page branch August 8, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
elixir Pull requests that update Elixir code enhancement New feature or request user story
Development

Successfully merging this pull request may close these issues.

2 participants