No More Premium #2869
Merged
No More Premium #2869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janvhs
added
tech debt
wip
javascript
|
Current open questions:
|
|
Preview: https://2869.prenv.trento.suse.com |
dottorblaster
force-pushed
the
remove-premium
branch
from
711a945 to
b266596
Compare
|
@janvhs no need to make a new openapi schema, let's just ship the old fields with sane defaults, stop reading them and mark them as deprecated so users can stop using them 👍 (and by doing this we keep backward compatibility) I just fixed a couple things, I had my fair round of testing and it looks like the app is ok |
dottorblaster
force-pushed
the
remove-premium
branch
from
d2d76fc to
26183ce
Compare
No more premium react experience :3
janvhs
force-pushed
the
remove-premium
branch
from
26183ce to
ef25107
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PREMIUM IS NO MORE
How was this tested?
Tests are still in place, removes tests which are not relevant anymore. More tests might have to be added to ensure backwards compatibility
Did you update the documentation?
Remember to ask yourself if your PR requires changes to the following documentation:
Add a documentation PR or write that no changes are required for the documentation.