Address flakiness in Activity Log tests #2836
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I experienced some flakiness in some of our activity log tests we've recently introduced.
It seems there is some inconsistency in how we slice data in pages. For example here the test fails because it was expecting two identical lists of entries in
next_logs_alt
andnext_logs
, but they where different. By re-running the job, the error disappeared.The problem may be in how we sort entries by date. As per the Elixir docs:
The fix improves how we sort data. We should keep an eye on the overall test, to see if it's enough do remove the flakiness.