-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pagination improvements, choice of items per page #2832
Conversation
Test's are still failing but maybe you want to have a look regardless? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some sparse comments but I think this is really good.
I noticed this is appearing on all the tables now, do we want this to happen? Do we want to have a prop to toggle this behavior? I don't have hard feelings about the direction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, feel free to rebase and merge 👍
Thanks Alessio <3
Description
Add support for choosing between multiple selections of items per page when doing pagination.
This affects all tables in the code-base.
How was this tested?
Jest and Storybook
Add a documentation PR or write that no changes are required for the documentation.