Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused prop in <Table /> component #2824

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Remove unused prop in <Table /> component #2824

merged 1 commit into from
Jul 26, 2024

Conversation

balanza
Copy link
Member

@balanza balanza commented Jul 25, 2024

Description

The withPadding property is completely overlapped by the config.usePadding property. We removed the first and used the latter when needed.

@balanza balanza requested review from EMaksy, a team and arbulu89 and removed request for a team July 25, 2024 17:26
@balanza balanza enabled auto-merge (squash) July 25, 2024 17:28
@balanza balanza disabled auto-merge July 25, 2024 17:28
@balanza balanza enabled auto-merge (squash) July 25, 2024 17:29
nelsonkopliku
nelsonkopliku approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The visual result seems to be unchaged.

@balanza balanza merged commit 3705fc2 into main Jul 26, 2024
26 checks passed
@balanza balanza deleted the remove-unused-field branch July 26, 2024 07:20
EMaksy
EMaksy reviewed Jul 26, 2024
View reviewed changes
Copy link
Member

@EMaksy EMaksy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care LGTM!

@nelsonkopliku nelsonkopliku added tech debt chore javascript Pull requests that update Javascript code labels Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EMaksy EMaksy EMaksy left review comments

@nelsonkopliku nelsonkopliku nelsonkopliku approved these changes

@arbulu89 arbulu89 Awaiting requested review from arbulu89 arbulu89 was automatically assigned from trento-project/developers

Assignees
No one assigned
Labels
chore javascript Pull requests that update Javascript code tech debt
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@balanza @nelsonkopliku @EMaksy