Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: move <Filter /> component #2823

Merged
merged 3 commits into from
Jul 26, 2024
Merged

Refactor: move <Filter /> component #2823

merged 3 commits into from
Jul 26, 2024

Conversation

balanza
Copy link
Member

@balanza balanza commented Jul 25, 2024

Description

The <Filter /> component has been moved out from the <Table /> component so that it can be used separately.
This is a preparatory work in order to enhance the usage of tables in more diversified scenarios.

No changes in the behavior of the component have been introduced (except for the default value).

All references to the component has been updated.

@balanza balanza requested review from nelsonkopliku, gagandeepb and a team July 25, 2024 17:20
@balanza balanza enabled auto-merge (squash) July 25, 2024 17:28
Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!
I shared a suggestion we might want to consider, although not blocking.

assets/js/common/Filter/Filter.stories.jsx Show resolved Hide resolved
Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balanza balanza merged commit 22f03c1 into main Jul 26, 2024
26 checks passed
@balanza balanza deleted the data-filters branch July 26, 2024 11:42
@nelsonkopliku nelsonkopliku added chore javascript Pull requests that update Javascript code labels Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore javascript Pull requests that update Javascript code
Development

Successfully merging this pull request may close these issues.

2 participants