Discover SAP system running on a JAVA stack

[EMaksy]

Description

This PR will enable the discovery of a SAP system running on a JAVA stack. A Java sap system is discovered and displayed in the SAP systems overview.

This pr adds a Type field in the Sap systems overview view, so the user can directly see if the discovered system is running on ABAP, JAVA or in a ABAP/JAVA.

Note: This pr contains a lot of almost duplicated back-end tests, this was needed to cover the new check for a sap system.
Previously we checked if a sap system runs on ABAP, now we check for ABAP and/or JAVA.

Preview from Storybook

Did you add the right label?

• DONE

How was this tested?

• Added fronted test

• Fixed cypress e2e test (New e2e tests will be added in a second pr as this pr gets a little bit too big)

• Updated existing and added new back-end sap systems tests.

• Updated storybook

• DONE

Did you update the documentation?

No updates needed at this point.

• DONE

[arbulu89]

Some nitpick comments in the frontend.
About the backend, and its test.
Do you think we need so many new tests for such a simple thing?
I mean, I think that simply with one new test would've been enough. Just a test to see that a j2ee instance emits the sap system discovered event. The rest of the scenarios are already well tested

[arbulu89]

Hey @EMaksy
Yet other set of comments about the frontend changes 😝

As a comment, now in Storybook, in SapSystemsOverview entry, all the types, always are ABAP/JAVA which is a totally exceptional deployment.
Could we have only ABAP or JAVA and the combo of both only in the custom story?

[arbulu89]

I understand what you are trying to test, but this entry you are putting is not a real scenario.
Here, if you want to test ABAP and JAVA together, you should have one instance with ABAP features and other instance with J2EE features. Not 1 instance with both, which doesn't exist

[arbulu89]

Creating a factory to modify just after that looks like an anti-pattern.
Why don't you create the value using the factory with the wanted entries?
Something maybe like:

const sapSystems = expectedSapSystemTypes
.map((type) => sapSystemFactory.build({ application_instances : applicationInstanceFactory.buildList(2, { features: type }))

[arbulu89]

Thank you buddy!
Looks great