Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use uuids for usernames in user factory #2762

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Use uuids for usernames in user factory #2762

merged 1 commit into from
Jul 9, 2024

Conversation

dottorblaster
Copy link
Contributor

Since we were getting occasional violations of primary keys for usernames in tests, I'm just switching to uuids for those in the dedicated factory.

@dottorblaster dottorblaster self-assigned this Jul 9, 2024
@dottorblaster dottorblaster requested a review from CDimonaco July 9, 2024 12:46
CDimonaco
CDimonaco approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@CDimonaco CDimonaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for addressing this issue!

@CDimonaco CDimonaco merged commit 9b68ece into main Jul 9, 2024
26 checks passed
@CDimonaco CDimonaco deleted the user-factory-uuid branch July 9, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CDimonaco CDimonaco CDimonaco approved these changes

Assignees

@dottorblaster dottorblaster

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dottorblaster @CDimonaco