Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prometheus target discovery endpoint #274

Merged
merged 3 commits into from
Mar 31, 2022
Merged

Add prometheus target discovery endpoint #274

merged 3 commits into from
Mar 31, 2022

Conversation

fabriziosestito
Copy link
Member

@fabriziosestito fabriziosestito commented Mar 31, 2022 •
edited
Loading

This PR adds the endpoint needed by prometheus to fetch the target hosts/exporters ports

image

arbulu89
arbulu89 approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too easy for you @fabriziosestito XD

@fabriziosestito fabriziosestito merged commit 99acee5 into main Mar 31, 2022
@fabriziosestito fabriziosestito deleted the add_prometheus_target_discovery_endpoint branch March 31, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arbulu89 arbulu89 arbulu89 approved these changes

@nelsonkopliku nelsonkopliku nelsonkopliku approved these changes

@rtorrero rtorrero Awaiting requested review from rtorrero

@stefanotorresi stefanotorresi Awaiting requested review from stefanotorresi

@dottorblaster dottorblaster Awaiting requested review from dottorblaster

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabriziosestito @nelsonkopliku @arbulu89