Activity log settings UI state

[balanza]

Description

Mount the Audit Logs section in the Settings Page.
The section at startup fetches the settings data from the backend and render them in the UI. To edit, a modal is open with editable form fields.
The database is prefilled with default settings, so there is no empty data scenario.

Changes

• rename field retentionTime to retention_time from Components for Activity Logs settings #2706 to adhere to API naming
• define reducer, selectors and sagas for handling the fetch and the update of the audit logs settings
• map the api operations
• mount the redux state
• mount the UI components in the SettingsPage page.

[nelsonkopliku]

Cool stuff! I left a few suggestions we might want to take into account.

Besides those, what do you think about having min={1} in the InputNumber inside TimeSpan?

It could help us in making illegal state unrepresentable and possibly simplifying a bit the frontend by being bit more loose in validation handling from the backend.

Happy to answer any question.

[nelsonkopliku]

We might be missing the opportunity to give the user a proper feedback on generic errors that might not fall into validation ones or that do not satisfy the expectation of a specific shape in the response body.

I forced the update endpoint to return 500, and I think it might be valuable to provide some feedback like unable to save retention time (or whatever message).

Screencast.from.2024-07-01.10-55-35.mp4

I am afraid a non-feedback might be misleading.

[balanza]

Good point. We can add a label aside the saving buttons, for global errors.

[balanza]

Added generic error in 09bea2e.

The UI simply shows the message Something went wrong while saving when an unstructured error appears (see storybook). We might provide a more descriptive message if we can add some intelligence to the error parsing, though..

[balanza]

Improved in 52303ca

[nelsonkopliku]

Great! Thanks!