Activity logger plug #2726
Merged
Activity logger plug #2726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelsonkopliku
added
enhancement
Co-authored-by: Gagandeep Bhatia <[email protected]>
Co-authored-by: Gagandeep Bhatia <[email protected]>
Co-authored-by: Gagandeep Bhatia <[email protected]>
nelsonkopliku
force-pushed
the
activity-logger-plug
branch
from
f05e2c9 to
9630194
Compare
gagandeepb
approved these changes
Jul 1, 2024
Comment on lines
+18
to
+22
| Task.Supervisor.start_child(Trento.TasksSupervisor, fn -> | ||
| conn | ||
| |> load_user() | ||
| |> ActivityLogger.log_activity() | ||
| end) |
There was a problem hiding this comment.
This might need to reconsidered at a later point when there is a db based ActivityLogger implementation. (Some sort of bounding of concurrency/back pressure might be necessary.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a Plug that loads the user for the current request and forwards the connection to an ActivityLogger that might or might not be interested in tracking current activity.
Actual implementation of the activity logger to followup.
How was this tested?
Automated tests