Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove navigate usage in redux action dispatching #2720

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

arbulu89
Copy link
Contributor

@arbulu89 arbulu89 commented Jun 26, 2024

Description

Remove navigate function usage in redux action dispatching. The navigate is coming now from the redux saga context

Related to: #2716

PD: And a fix for the toaster location that i have messed during previous PR conflicts resolution...

@arbulu89 arbulu89 requested review from CDimonaco and EMaksy June 26, 2024 14:07
@arbulu89 arbulu89 marked this pull request as ready for review June 26, 2024 14:21
@arbulu89 arbulu89 force-pushed the remove-navigate-from-redux-actions branch from fbe7fef to 7a75955 Compare June 26, 2024 14:22
Copy link
Member

@CDimonaco CDimonaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

Just a nipick, if we want we can assign the context entry name router to a const when we inject first time and import it where we need, but it's really a nitpick

@arbulu89 arbulu89 merged commit 8c97258 into main Jul 2, 2024
26 checks passed
@arbulu89 arbulu89 deleted the remove-navigate-from-redux-actions branch July 2, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants