Make SUSE Manager section in Host Details page reactive #2593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamie-suse
added
enhancement
jamie-suse
changed the title
Software Updates settings data reactive
nelsonkopliku
requested changes
May 6, 2024
There was a problem hiding this comment.
Good job!
We just need to leverage SoftwareUpdatesDiscoveryEventHandler event handler and do relevant things when specific other relevant things happen 😄
Besides this, what happens when a host gets deregistered or settings are cleared?
We might want that reactiveness also in these cases.
lib/trento/infrastructure/commanded/event_handlers/software_updates_discovery_event_handler.ex
Show resolved
Hide resolved
dottorblaster
force-pushed
the
reactive-sw-updates
branch
from
30e0e84 to
60adfd3
Compare
nelsonkopliku
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds the ability for Trento to send a WebSocket message to indicate that the software update discovery for a given host has been completed (
HOST_SOFTWARE_UPDATES_DISCOVERY_COMPLETED).When a client receives the
HOST_SOFTWARE_UPDATES_DISCOVERY_COMPLETEDmessage, the client then requests the software updates settings information, and then also requests the software updates of a given host.How was this tested?