Change software_updates_discovery_health default value
#2528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelsonkopliku
force-pushed
the
refactor-software-updates-completion-command
branch
from
ca3e8f2 to
b741de3
Compare
nelsonkopliku
added
enhancement
nelsonkopliku
changed the title
software_updates_discovery_health default health
nelsonkopliku
changed the title
software_updates_discovery_health default healthsoftware_updates_discovery_health default value
arbulu89
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
Looking good!
My unique concern is that we don't check for the current software discovery health when we receive the command, because if the health is the same, we don't need to emit the event.
Besides that, (except no_set/unset term, which I hope @jamie-suse can help), everything looks good.
PD: Let's not merge this in a hurry. We need to see the currently changed things in demo (like tags, selected checks, etc), as we will need to recreate the db and event store
| Type that represents the possible health values for the software updates discovery process. | ||
| """ | ||
|
|
||
| use Trento.Support.Enum, values: [:passing, :warning, :critical, :unknown, :not_set] |
There was a problem hiding this comment.
Maybe unset is more appropriate that not_set.
What does our anglo native @jamie-suse say hehe ?
nelsonkopliku
force-pushed
the
refactor-software-updates-completion-command
branch
from
91fe6d0 to
614c3bc
Compare
…lth does not actually change
nelsonkopliku
force-pushed
the
refactor-software-updates-completion-command
branch
from
614c3bc to
fd7e957
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR
software_updates_discovery_healthis changed fromunknowntonot_set(required in followup changes settingsoftware_updates_discovery_healthand consequently host's health to unknown on discovery errors)software_updates_discovery_healthbased on discovered patches is moved from the Host aggregate to the DiscoverySoftwareUpdatesDiscoveryCompletedis changed toSoftwareUpdatesHealthChangedcarrying only the computed healthHow was this tested?
Automated tests.