Add intermediate confirmation step in ApiKeySettingsModal #2514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CDimonaco
added
enhancement
CDimonaco
force-pushed
the
api_key_settings_confirmation_modal
branch
from
09f6653 to
d56d0d4
Compare
|
@CDimonaco Thanks for this. This works well for me and I see that it retains the state (values of) nicely. 😄 I would like you to add a full stop (.) at the end of the last sentence, "This action cannot be undone". I will double check the warning message in general with @abravosuse. |
|
@CDimonaco Can we also change the warning message to say " ...on all the registered hosts." instead of " ...in all the registered hosts." So the full message is this... "Generating a new API Key forces an update of the agent configuration on all the registered hosts. This action cannot be undone." |
arbulu89
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add confirmation modal in ApiKeySettings dialog, to double check if the user wants to generate a new Api key
How was this tested?
Automated/e2e tests