Display errors in SUSE Manager settings form #2455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottorblaster
changed the title
| onClearErrors(); | ||
| }} | ||
| /> | ||
| <div className="col-span-4"> |
There was a problem hiding this comment.
What about embedding the error in the input component?
<Input
value={url}
placeholder="Enter a URL"
error={getError('url', errors)}
onChange={({ target: { value } }) => {
setUrl(value);
onClearErrors();
}}
/>Really up to you 😄 There are just many hasError and related getError.
I am fine either way
There was a problem hiding this comment.
This is something I'd be up to but it would tie us to one single implementation of error visualization and I want to wait instead for more form implementations to see what we settle upon.
nelsonkopliku
requested changes
Mar 22, 2024
dottorblaster
force-pushed
the
display-errors-suse-manager-settings
branch
from
b1abc6e to
e816e64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Displaying validation errors in the SUSE Manager settings modal.
How was this tested?
Jest tests, Storybook