Add Redux Sagas for getting SUSE Manager software updates #2416
Conversation
There was a problem hiding this comment.
Good job, Jamie.
It's a good starting point, however I think we need to keep iterating in order to make things click.
There might be edge cases I've overlooked, but let's make it work first, then we polish what needs fine tuning 😉
Hope the comments are somewhat useful. Happy to help.
There was a problem hiding this comment.
Cool, good enhancements!
I guess we just need to change software_updates to upgradable_packages 😝
What I am actually missing is the clicking part on error occurrence, cause I am not sure yet what the backed would return. #2415 (comment)
I am afraid we need to keep this a bit on hold.
assets/js/state/softwareUpdates.js
Outdated
| state.softwareUpdates = Object.entries(state.softwareUpdates).reduce( | ||
| (newState, [id, updates]) => | ||
| id !== hostId ? { ...newState, [id]: updates } : newState, | ||
| {} | ||
| ); |
There was a problem hiding this comment.
| state.softwareUpdates = Object.entries(state.softwareUpdates).reduce( | |
| (newState, [id, updates]) => | |
| id !== hostId ? { ...newState, [id]: updates } : newState, | |
| {} | |
| ); | |
| state.softwareUpdates = { | |
| ...state.softwareUpdates, | |
| [hostId]: {}, | |
| }; |
What do you think?
There was a problem hiding this comment.
Sure, I think it's good. It got me thinking though; what do we think about clearing setting [hostId]: { relevant_patches: [], upgradable_packages: [] } as opposed to [hostId]: {}?
There was a problem hiding this comment.
On second thought, it might be bad as the selector would report relevant_patches/upgradable_packages == 0 instead of undefined. But as @nelsonkopliku mentioned, error handling should handle this before it even hits the selector 🤔
There was a problem hiding this comment.
No strong opinion, let's ship whatever you prefer 👍
There was a problem hiding this comment.
I like having a semantic difference between undefined vs 0. Sure, the error handling should handle this but it still gives a more semantically correct representation of the state of the system.
Description
Add Redux Sagas to allow retrieval of software updates for a given host.
This PR also includes Selectors to derive the number of relevant patches and upgradable packages from the state.
How was this tested?
Added unit tests.