Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces domain logic to handle clearing up of software updates discovery results.
Basically when a user clears up suma credentials, whatever has been previously discovered, gets ignored.
Specifically the health of the software updates discovery gets ignored from the host's aggregated health.
This is going to happen in a loop for all the hosts meaning that a bunch of
HostHealthChanged
could be emitted upon creds clear up, with related ui notifications.We could avoid these possibly many extra events by changing the aggregated health of a host silently when
SoftwareUpdatesDiscoveryCleared
, but meh... the host's health does change and it'd feel like we'd be missing something in the history.How was this tested?
Automated tests