Api key expiration frontend notifications #2388
Conversation
CDimonaco
added
enhancement
There was a problem hiding this comment.
LGTM @CDimonaco , only few minor things. Also, would it make sense to have the DismissibleToast component in storybook?
There was a problem hiding this comment.
I think the correct word would be Dismissible
There was a problem hiding this comment.
We can change it, I googled and the two forms are both valid, idk
There was a problem hiding this comment.
I prefer Dismissable. It looks more correct in this case
There was a problem hiding this comment.
Really nice @CDimonaco
I left some nitpick comments.
I guess that the visualization of the api key itself in the settings page will have its own sagas/queries, right?
| expect(dispatched).toEqual([]); | ||
| }); | ||
|
|
||
| it('should dispatch an expired key notification if the expire_at of the api key is in the past', async () => { |
There was a problem hiding this comment.
for me these test description texts are a bit awkard, but well, i can live with that XD
|
@rtorrero Storybook for the component it's not needed, it's not a real "visual" component, in storybook is just a div without style, it's meant to be used inside the toast library wrapper, who injects styles and icon |
CDimonaco
force-pushed
the
api_key_expiration_frontend_toast
branch
from
524b9eb to
8c2d9d8
Compare
There was a problem hiding this comment.
I prefer Dismissable. It looks more correct in this case
|
Is it possible to add this to Storybook? I would like review it in the browser. 😅 |
It's completely useless to have in storybook like I was saying in the other comment, it's an unstyled piece of html, the result is in the screenshot and the library itslef provide the style to the toast, I can put a button in storybook to spawn a toast but Idk if it's really useful |
Sorry I missed that comment. I would find it useful to review the component and just make sure it renders the same and that there will be consistency in the future should changes occur. |
CDimonaco
force-pushed
the
api_key_expiration_frontend_toast
branch
2 times, most recently
from
c0d1b0d to
ea73402
Compare
Description
When the trento frontend application loads, we fetch the api key expiration.
If the api key is expired, the frontend shows a persistent toast.
If the api key will expire in 30 days, the frontend shows a dismissable toast.
This pr also adds a dismissable toast, and a custom notification dispatching with custom duration and dismissable.
How was this tested?
Automated tests, e2e tests