Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a clear operation to suma service #2386

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Add a clear operation to suma service #2386

merged 1 commit into from
Mar 7, 2024

Conversation

nelsonkopliku
Copy link
Member

@nelsonkopliku nelsonkopliku commented Mar 6, 2024 •
edited
Loading

Description

Adding a clear feature to the suma integration service that wipes out its internal state.

We might end up in adding the clear function in the discovery behaviour, but I'll add that later if actually needed (I guess so 😄 )

How was this tested?

Automated tests.

@nelsonkopliku nelsonkopliku self-assigned this Mar 6, 2024
@nelsonkopliku nelsonkopliku added enhancement New feature or request user story elixir Pull requests that update Elixir code labels Mar 6, 2024
dottorblaster
dottorblaster approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nelsonkopliku nelsonkopliku changed the title Add a clear operation to suma service state Add a clear operation to suma service Mar 6, 2024
jamie-suse
jamie-suse approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@jamie-suse jamie-suse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@nelsonkopliku
Copy link
Member Author

@dottorblaster @jamie-suse thanks for the review.
Just for everyone to be aware I am having doubts whether this operation should be a call or a cast, fire and forget.
As we keep going on it we'll discover and eventually refactor, if needed.
Merging for now 👍

@nelsonkopliku nelsonkopliku merged commit 4cd9e99 into main Mar 7, 2024
36 checks passed
@nelsonkopliku nelsonkopliku deleted the clear-suma-client-state branch March 7, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamie-suse jamie-suse jamie-suse approved these changes

@dottorblaster dottorblaster dottorblaster approved these changes

Assignees

@nelsonkopliku nelsonkopliku

Labels
elixir Pull requests that update Elixir code enhancement New feature or request user story
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nelsonkopliku @dottorblaster @jamie-suse